Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for bitwise and/or/xor for decimal type #94

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Add test cases for bitwise and/or/xor for decimal type #94

merged 2 commits into from
Aug 23, 2024

Conversation

anshuldata
Copy link
Contributor

  • duckdb doesn't support bitwise and/or/xor for decimal type so not supported in duckdb dialect
  • Set scale/precision based on Substrait spec (here) which is as follows for bitwise_and/or/xor :
    Input: (<P1, 0>, <P2, 0>) ==> Result: <max(P1, P2), 0>)

@anshuldata anshuldata mentioned this pull request Aug 22, 2024
Closed
@jacques-n jacques-n force-pushed the BitwiseAndOrXorDecimalFunc_New branch from 277c2c0 to 0961d79 Compare August 22, 2024 16:58
@anshuldata anshuldata force-pushed the BitwiseAndOrXorDecimalFunc_New branch from 0961d79 to 50ab8e1 Compare August 23, 2024 06:13
@anshuldata anshuldata force-pushed the BitwiseAndOrXorDecimalFunc_New branch from 50ab8e1 to c89a946 Compare August 23, 2024 06:17
@richtia richtia merged commit 136a324 into substrait-io:main Aug 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtia richtia richtia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshuldata @richtia