Shearwater: Hide Sensor Calibration Information for Open Circuit Dives.

[mikeller]

Don't show the O2 sensor calibration settings in 'Extra Info' when the
dive is not a rebreather dive.

[Copilot]

Pull Request Overview

This PR updates the sensor calibration handling logic in the Shearwater Predator parser to hide O₂ sensor calibration data for open circuit dives.

• Introduces a conditional retrieval of dive mode when the log version is 8 or higher.
• Caches sensor calibration only if the dive mode indicates a rebreather dive (M_CC, M_CC2, or M_SC).
• Removes a redundant block of code that previously extracted the dive mode later in the function.

Comments suppressed due to low confidence (1)

src/shearwater_predator_parser.c:779

• Consider adding a comment to clarify the significance of the constants 6 and 86 when computing the base index for sensor calibration.

unsigned int base = parser->opening[3] + (pnf ? 6 : 86);

[Copilot]

Consider adding a comment to explain the rationale behind the constant 112 (and 1) offset used to retrieve the dive mode from the header.

Suggested change

	divemode = data[parser->opening[4] + (pnf ? 1 : 112)];
	// The offset 112 is used to retrieve the dive mode from the header for non-PNF logs.
	// For PNF logs, the offset is 1. These offsets are determined by the log format specifications.
	const unsigned int DIVE_MODE_OFFSET_NON_PNF = 112;
	const unsigned int DIVE_MODE_OFFSET_PNF = 1;
	divemode = data[parser->opening[4] + (pnf ? DIVE_MODE_OFFSET_PNF : DIVE_MODE_OFFSET_NON_PNF)];