Allow variable to find_xquery

sue445 · Oct 20, 2021 · f3191f8 · f3191f8
1 parent 6571282
commit f3191f8
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/rubocop/cop/isucon/mixin/mysql2_methods.rb b/lib/rubocop/cop/isucon/mixin/mysql2_methods.rb
@@ -9,17 +9,19 @@ module Mysql2Methods
           extend NodePattern::Macros
 
           def_node_search :find_xquery, <<~PATTERN
-            (send (send nil? _) {:xquery | :query} (${str dstr} $...) ...)
+            (send (send nil? _) {:xquery | :query} (${str dstr lvar ivar cvar} $...) ...)
           PATTERN
 
           # @param node [RuboCop::AST::Node]
           # @yieldparam type [Symbol] Node type. one of `:str`, `:dstr`
-          # @yieldparam root_gda [RuboCop::Isucon::GDA::Client]
+          # @yieldparam root_gda [RuboCop::Isucon::GDA::Client,nil]
+          #
+          # @note If arguments of `db.xquery` isn't string, `root_gda` is `nil`
           def with_xquery(node)
             find_xquery(node) do |type, params|
               sql = xquery_param(type: type, params: params)
 
-              root_gda = RuboCop::Isucon::GDA::Client.new(sql)
+              root_gda = sql ? RuboCop::Isucon::GDA::Client.new(sql) : nil
 
               yield type, root_gda
             end