🐛 Ignore Old AppMentions Events #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a check to the AppMention event handler, to check how recent the message was created. If the message is greater than 2 seconds old, it will be ignored. This will prevent the bot responding to edited, older messages. Previously, the bot would respond to any incoming AppMention event, regardless of how old the message was. Fixes #16.
|
Yeah this sucks, but welcome to the Slack API! 🎉 I tried checking something along the lines of a So dirty time hacks it is! |
Eunoseer
approved these changes
Sep 24, 2023
There was a problem hiding this comment.
It's a shame that the slackEvents go package doesn't seem to support the concept of "message_changed". It looks like the "AppMentionEvent" struct holds the "message" data from the event. There appears to be an open issue against the slack-go library which if resolved could give us the data we need?
Note the "edited" data in the example payload.
Slack-Go issue #961
dHeinemann
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check to the AppMention event handler, to check how recent the message was created. If the message is greater than 2 seconds old, it will be ignored. This will prevent the bot responding to edited, older messages.
Previously, the bot would respond to any incoming AppMention event, regardless of how old the message was.
Fixes #16.