Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Made ToolBar Icons Responsive #4356

Merged

Conversation

arjunjayan999
Copy link
Contributor

@arjunjayan999 arjunjayan999 commented Feb 6, 2025

This PR fixes issue #4351 and includes several changes to the lib/materialize-iso.css file, primarily focusing on adjusting the font sizes and widths of icons within navigation elements.

Font size adjustments:

  • Increased the font size of .materialize-iso nav .aux i.material-icons from 32px to 48px.
  • Changed the font size of .materialize-iso nav .main i.material-icons and .materialize-iso nav .aux i.material-icons from fixed pixel values to viewport width units (5.3vw).
  • Updated the font size of .materialize-iso nav .main i.material-icons and .materialize-iso nav .aux i.material-icons to 7.5vw and adjusted the margin values accordingly.

Width adjustments:

  • Removed the width properties from .materialize-iso nav .main i.material-icons and .materialize-iso nav .aux i.material-icons.

Before

image

After

Responsive.Toobar.Icons.mp4

Note

  • It now accomodates till the width of 525px or so, beyond this it is better to implement a hamburger menu of sorts for navbar. That is why I have not handled the media query of 400px in PR.

@arjunjayan999
Copy link
Contributor Author

@walterbender please review it.

@walterbender walterbender merged commit 1880f7c into sugarlabs:master Feb 6, 2025
4 checks passed
@arjunjayan999 arjunjayan999 deleted the fix/responsive-toolbar-icons branch February 7, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants