jest test suite for js/macros.js #4359
Merged
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walterbender please review this |
|
@walterbender I have a question in my mind and wanna ask you like should I add multiple test in a single pr or separate tests in separate pr which would we easier for you to review |
|
@omsuneri I am also interested in writing tests. What are the files you are targeting next? Let's divide the work if you are okay with it. |
|
@Commanderk3 fine I m on the js directory would be trying to tackle some big files try doing form the smaller one with less functions I guess I ll mention you soon which I m creating and then you can have the left ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@walterbender i had added the test for the js/macros.js and it works absolutely fine.
