Adding Info Page for Community Channels #616
Conversation
|
@quozl this time I add all the files in a single commit as they all are added to to create a single page only so is it the correct way or any changes required |
|
looks very nice! |
|
Thanks @retrogtx |
|
My idea for screenshots were to help a newbie understand what to see when navigating creating an account for the first time. I don't think you should use those screenshots. This is more of what I was thinking of:
In fact, that one screenshot is probably sufficient. We may want to also find an "official" how-to for registering to Matrix for the first time that we can link to, so that we know we're sending people to something that's probably always up-to-date, and that we don't have to maintain ourselves. |
|
@pikurasa okay so i ll be deleting the images and also trying to add more text information about the make account creation and also try to search some matrix link to their guide for creating an account for matrix and again similar for discord too. |
Yes. If you have any questions, please let me know. |
|
Yeah @pikurasa I ll be making this soon as in my device I m getting many dependencies issue with the www repo I m trying to reset it @haroon10725 just wait for some as I did many changes if It not possible by you can surely take this issue but wait for sometime atleast |
|
@omsuneri No problem, will continue from here. |
|
@haroon10725 I ll inform you if it works me on 01/16 meet will discuss about this topic |
|
@pikurasa now i m having a fedora Virtual Machine on my mac through which i can run the repo and will be resolving all the conflicts and making this PR to be done by tomorrow |
|
@pikurasa as the elements create ac page should i also add the same for the discord too as we are displaying the info about both the paltforms so might be good to add both the platform create acc page |
Now the beginner to the sugar labs would get a better interface and informatio about the community channels on discord and elements and also can understand how to create an account on this platforms.
https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#making-commits You should be reading existing commits in a repository and matching or uplifting the change and commit message style. Also read closed issues and pull requests. When we see work submitted without any evidence of this, it scores very badly. You can do what we've asked without closing the pull request and opening a new one, by rebasing your branch and force push. |
|
@quozl i tried to resolve all of the conflicts according to your suggestions |
|
@pikurasa all conflicts with master are resolved please review it again |
|
You haven't done any of the changes I asked for;
Try harder. |
|
Sorry @quozl but I moved the css from airspace to custom |
What he meant was that file is changed unnecessarily, so that could be removed, use To rebase and squash the commits so that you remove unnecessary commits and make commits as per what changes you are making clearly stating what each commit did. |
|
There are many ways to reduce the commits, interactive rebase offers some ways, as does a reset followed by new commits. Look at Git documentation. |
assets/Elements.png
Outdated
There was a problem hiding this comment.
This image seems good to me, but please optimize the image. You should be able to make it smaller.
There was a problem hiding this comment.
i m unable to understand the requirement can you describe more please @pikurasa
There was a problem hiding this comment.
Use a png to jpeg or jpg converter and use that instead, keeping a file size like this causes the site to slow down
assets/Discord.png
Outdated
There was a problem hiding this comment.
This image seems good to me, but please optimize the image. You should be able to make it smaller.
There was a problem hiding this comment.
@pikurasa can you describe more
There was a problem hiding this comment.
Use a png to jpeg or jpg converter and use that instead, keeping a file size like this causes the site to slow down
|
@pikurasa i resolved all the conflicts with this PR check it once |
js/custom.js
Outdated
| @@ -17,54 +17,48 @@ function toggleAnswer(answerId, element) { | |||
| // Counter Animation of the home page | |||
There was a problem hiding this comment.
yeah changes on this file are just not required
assets/Discord.png
Outdated
There was a problem hiding this comment.
Use a png to jpeg or jpg converter and use that instead, keeping a file size like this causes the site to slow down
assets/Elements.png
Outdated
There was a problem hiding this comment.
Use a png to jpeg or jpg converter and use that instead, keeping a file size like this causes the site to slow down
| @@ -2777,7 +2777,7 @@ font-size:30px; | |||
| .try-mb:active { | |||
| top:0.1em; | |||
| color: #fff !important; | |||
| } | |||
| } | |||
| } |
|
Please remove your unintended change to css/airspace.css You can and should do this without opening a new pull request; use standard git techniques to restore the file to the point it was before your work, then commit the file alone. We could do it for you, but we'd prefer you do it. |
Creating Informative Page for the Community Channel
New page in website provides more understanding to the community channel for chat and discussion