-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing dependencies issue by updating Gemfile #676
Conversation
@pikurasa Ive created a new pr. Please review this |
That's a future deprecation warning, not an error. Issue closed. You're apparently updating the dependencies using one of the steps mentioned in But without the other steps, this change would likely break the web site deployment build. |
Hi @quozl, Error Screenshot:After investigating, I found that the issue was caused by missing dependencies. To resolve this, I had raised a PR that fixes the problem. Please review it. introduced the problem. I look forward to your response. Best regards. |
As I said, we're using Jekyll 3, and moving to Jekyll 4 as you have suggested will be a complex process that risks the build and deploy of the web site. I don't see any sign that you know what you are talking about in the context of that process. While you may be happy with the fix to your own environment, that's not the environment we work with. |
I've reviewed the PR, and I don't quite see where this PR would move us to Jekyll 4. While we might not know for certain if it would work on GH if merged, FWIW it does work on my machine. Also, in some ways it seems like a simplification, since it is removing constraints on which versions to load. So I assume that whatever setup you have, your system resolves the dependencies on its own. So, I'm not totally certain yet that we write this PR off. That said, I never encountered the issue. So it's value is mainly in helping contributors using Mac/Windows up and running with fewer problems, and it doesn't solve any pressing issues with deployment. |
@pikurasa Yes they would automatically solve the dependency errors. Also new begginers wouldn't be facing issue they are facing now if this is merged. Can i go ahead with a new pr ? |
I've not yet found a good reason to move to Jekyll 4. New beginners could use the Docker set up by @MostlyKIGuess, but the biggest mistake seems to be their choice of task; mostly cosmetic. Changes to content in response to changes in the environment, code, or use of Sugarizer, Music Blocks, or Sugar would be more welcome. You can have more than one pull request open at a time, that's your choice. Just don't mix the branches and be ready to rebase when master branch moves. It's a skill. |
When running bundle exec jekyll serve --incremental, an error occured. Investigation reveals that the issue is due to missing dependencies in the Gemfile, which was introduced by Commit
1dd0e41.
The changes in this commit removed essential dependencies, leading to this error.