Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing dependencies issue by updating Gemfile #676

Closed
wants to merge 1 commit into from

Conversation

sa-fw-an
Copy link
Member

@sa-fw-an sa-fw-an commented Feb 2, 2025

When running bundle exec jekyll serve --incremental, an error occured. Investigation reveals that the issue is due to missing dependencies in the Gemfile, which was introduced by Commit 1dd0e41. The changes in this commit removed essential dependencies, leading to this error.

@sa-fw-an
Copy link
Member Author

sa-fw-an commented Feb 2, 2025

@pikurasa Ive created a new pr. Please review this

@quozl
Copy link
Contributor

quozl commented Feb 2, 2025

That's a future deprecation warning, not an error. Issue closed.

You're apparently updating the dependencies using one of the steps mentioned in
#634 (comment)

But without the other steps, this change would likely break the web site deployment build.

@quozl quozl closed this Feb 2, 2025
@sa-fw-an
Copy link
Member Author

sa-fw-an commented Feb 3, 2025

Hi @quozl,
I've attached a screenshot of the error that occurs when running bundle exec jekyll serve --incremental

Error Screenshot:


Screenshot 2025-02-03 at 7 19 38 AM

After investigating, I found that the issue was caused by missing dependencies. To resolve this, I had raised a PR that fixes the problem. Please review it.
To troubleshoot, could you try setting up the dev environment again after removing all locally installed gems? This will help verify if the error persists.
Others have encountered the same issue, and it's likely that PR

introduced the problem. I look forward to your response.

Best regards.

@quozl
Copy link
Contributor

quozl commented Feb 3, 2025

As I said, we're using Jekyll 3, and moving to Jekyll 4 as you have suggested will be a complex process that risks the build and deploy of the web site. I don't see any sign that you know what you are talking about in the context of that process.

While you may be happy with the fix to your own environment, that's not the environment we work with.

@pikurasa
Copy link
Contributor

pikurasa commented Feb 5, 2025

I've reviewed the PR, and I don't quite see where this PR would move us to Jekyll 4.

While we might not know for certain if it would work on GH if merged, FWIW it does work on my machine.

Also, in some ways it seems like a simplification, since it is removing constraints on which versions to load. So I assume that whatever setup you have, your system resolves the dependencies on its own.

So, I'm not totally certain yet that we write this PR off.

That said, I never encountered the issue. So it's value is mainly in helping contributors using Mac/Windows up and running with fewer problems, and it doesn't solve any pressing issues with deployment.

@sa-fw-an
Copy link
Member Author

sa-fw-an commented Feb 5, 2025

I've reviewed the PR, and I don't quite see where this PR would move us to Jekyll 4.

While we might not know for certain if it would work on GH if merged, FWIW it does work on my machine.

Also, in some ways it seems like a simplification, since it is removing constraints on which versions to load. So I assume that whatever setup you have, your system resolves the dependencies on its own.

So, I'm not totally certain yet that we write this PR off.

That said, I never encountered the issue. So it's value is mainly in helping contributors using Mac/Windows up and running with fewer problems, and it doesn't solve any pressing issues with deployment.

@pikurasa Yes they would automatically solve the dependency errors. Also new begginers wouldn't be facing issue they are facing now if this is merged. Can i go ahead with a new pr ?

@quozl
Copy link
Contributor

quozl commented Feb 5, 2025

I've not yet found a good reason to move to Jekyll 4. New beginners could use the Docker set up by @MostlyKIGuess, but the biggest mistake seems to be their choice of task; mostly cosmetic. Changes to content in response to changes in the environment, code, or use of Sugarizer, Music Blocks, or Sugar would be more welcome.

You can have more than one pull request open at a time, that's your choice. Just don't mix the branches and be ready to rebase when master branch moves. It's a skill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running bundle exec jekyll serve --incremental due to missing dependencies while set up
3 participants