Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enabling gzip for request body decompression #236

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

oestradiol
Copy link
Contributor

@oestradiol oestradiol commented Sep 20, 2024

The latest ATProto update completely broke our client because gzip was not enabled...
I'm not sure, but I think it was caused by this PR since everything started to error around the time it was merged.
Example of broken endpoint: app.bsky.feed.getAuthorFeed

It seems that all we have to do for reqwest is enable a feature flag, but we need to check if isahc is working or not, and quickly implement a fix if it's not. This is very high priority. I can't finish it right now since it's very late and I'm about to go to sleep...

@sugyan, I'm not sure if I'll be awake when you see this, so feel free to work on this yourself, if you have to. I'm giving you access to my fork of atrium just in case, but if you prefer, you can also close this PR and make a separate branch for it.

@sugyan
Copy link
Owner

sugyan commented Sep 20, 2024

Thanks a lot!
As far as I've tried, isahc client seems to work fine, I didn't know that we had to enable the gzip feature in reqwest to get it decompressed...

@sugyan sugyan merged commit 1e8094b into sugyan:main Sep 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants