Properly handle terminated connection by the server and fix CI #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ClickhouseTransport::poll_next did not tries to process packets if the server closed the connection, however there can be some packet (likely Exception), that we need to pass to user. Also this will avoid panic in case of missing Hello packet, i.e. in case of credentials mismatch.
azat
changed the title
azat
added a commit
to azat/chdig
that referenced
this pull request
Apr 15, 2025
…tication (#86) Refs: suharev7/clickhouse-rs#226 Fixes: #84
|
@suharev7 kind ping on this one (it will fix CI that is broken now and some minor fixes for connection) |
|
FWIW I also have an mTLS support here - azat-rust#3 Will submit it after this (due to conflicts in CI) |
|
Hi @suharev7. Kind ping on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ClickhouseTransport::poll_next did not tries to process
packets if the server closed the connection, however there can be some
packet (likely Exception), that we need to pass to user.
Also this will avoid panic in case of missing Hello packet, i.e. in
case of credentials mismatch.