-
Notifications
You must be signed in to change notification settings - Fork 397
⚡️(frontend) improve accessibility of selected document's sub-menu #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ovgodd
wants to merge
17
commits into
main
Choose a base branch
from
fix/1160-sub-doc-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3463226
to
a4249b3
Compare
6d0eba4
to
069359a
Compare
6b4c0e9
to
6eb9036
Compare
subdocnavarrow.mp4Fixed ! |
161ec74
to
46f6274
Compare
46f6274
to
43a996f
Compare
adds focus style to make the sub-menu accessible unify dropdownmenu Signed-off-by: Cyril <[email protected]>
enter/space now trigger only on real focus add useTreeItemKeyboardActivate hook Signed-off-by: Cyril <[email protected]>
adds proper aria props and translation keys for accessibility support Signed-off-by: Cyril <[email protected]>
f9cf2a9
to
2907b3e
Compare
Size Change: +2.86 kB (+0.08%) Total Size: 3.64 MB
|
2907b3e
to
ae9f348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR improves the keyboard accessibility of the document tree following the WAI-ARIA Authoring Practices (APG) and WCAG 2.1 guidelines.
Issue: #1160
Sub-document navigation is now fully accessible: users can navigate and open sub-documents using the keyboard.
Keyboard interactions
Accessibility compliance
Benefits
Proposal
For the action buttons (like “more options” or “add child document”) that appear when a tree item is focused:
useActionableMode
hook to manage focus and keyboard interactions.:focus-within
on the tree item wrapper to show the contextual action menu when a child receives focus.:focus-visible
outlines on buttons inside the menu for clear visual feedback.aria-label
attributes to make icon-only buttons screen reader accessible (e.g., “More options”, “Add child document”).onKeyDown
handlers to support Enter and Space on icon buttons.