Skip to content

✏️(frontend) fix GitHub capitalization #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karlhorky
Copy link

@karlhorky karlhorky commented Aug 7, 2025

Purpose

Fix capitalization of the brand GitHub

Proposal

  • Fix capitalization of GitHub

External contributions

Thank you for your contribution! 🎉

Please ensure the following items are checked before submitting your pull request:

  • I have read and followed the contributing guidelines
  • I have read and agreed to the Code of Conduct
  • I have signed off my commits with git commit --signoff (DCO compliance)
  • I have signed my commits with my SSH or GPG key (git commit -S)
  • My commit messages follow the required format: <gitmoji>(type) title description
  • I have added a changelog entry under ## [Unreleased] section (if noticeable change)
  • I have added corresponding tests for new features or bug fixes (if applicable)

@karlhorky karlhorky force-pushed the patch-1 branch 4 times, most recently from 3031a25 to 17f452f Compare August 7, 2025 10:31
The capitalization of the product GitHub has a capital H
@karlhorky karlhorky changed the title Fix GitHub capitalization ✏️(frontend) fix GitHub capitalization Aug 8, 2025
@karlhorky
Copy link
Author

karlhorky commented Aug 8, 2025

@AntoLC looking at the CI failures:

  1. 3: B6 Body message is missing https://github.com/suitenumerique/docs/actions/runs/16801989694/job/47633068291
  2. Check that the CHANGELOG has been modified in the current branch https://github.com/suitenumerique/docs/actions/runs/16801989694/job/47633068314

For 1, not sure if this commit format is correct?

For 2, I was trying to understand what it is trying to tell me. At first glance, it appears to want a changelog entry for this PR. However, looking at the workflow, it shows an exception for PRs with noChangeLog labels.

Should this PR have this noChangelog label? Or should I actually add a changelog entry for this typo fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant