Skip to content

Conversation

Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Oct 8, 2025

Purpose

Allow the logo used in the Docs header to be overridden at deployment time using Kubernetes ConfigMaps.

issue : 1308

Proposal

  • Replace inline/bundled logo with <Image src="/assets/icon-docs.svg" />
  • Use Next.js Image component

@Ovgodd Ovgodd requested a review from AntoLC October 8, 2025 06:47
@Ovgodd Ovgodd self-assigned this Oct 8, 2025
@Ovgodd Ovgodd force-pushed the fix/1308-replace-embedding-logo branch from 98879b7 to 0f811f5 Compare October 8, 2025 06:48
@Ovgodd Ovgodd marked this pull request as ready for review October 8, 2025 06:49
@Ovgodd Ovgodd force-pushed the fix/1308-replace-embedding-logo branch 4 times, most recently from 9545c10 to 1a9f4c1 Compare October 9, 2025 14:30
CHANGELOG.md Outdated
- 🐛(backend) filter invitation with case insensitive email
- 🐛(frontend) reduce no access image size from 450 to 300 #1463
- 🐛(frontend) preserve interlink style on drag-and-drop in editor #1460
- ✨(frontend) load docs logo from public folder via url instead of bund… #1462
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ovgodd Ovgodd force-pushed the fix/1308-replace-embedding-logo branch 4 times, most recently from ef46db2 to 5fded8d Compare October 9, 2025 19:41
Copy link

github-actions bot commented Oct 9, 2025

Size Change: -35 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/8426b957/_buildManifest.js 0 B -881 B (removed) 🏆
apps/impress/out/_next/static/chunks/8495.js 51.2 kB -886 B (-1.7%)
apps/impress/out/_next/static/chunks/pages/home.js 7.9 kB +857 B (+12.16%) ⚠️
apps/impress/out/_next/static/531a18ba/_buildManifest.js 883 B +883 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/1308-replace-embedding-logo branch 3 times, most recently from 50b6652 to 5a8da40 Compare October 13, 2025 05:32
Ovgodd and others added 2 commits October 13, 2025 08:15
allows logo override at deploy-time using k8s configmaps and static assets

Signed-off-by: Cyril <[email protected]>
In development mode, we will reduce the cache timeout
for theme customization to 15 seconds.
This change allows developers to see updates
to theme settings more quickly without needing
to clear the cache manually.
@Ovgodd Ovgodd force-pushed the fix/1308-replace-embedding-logo branch from 5a8da40 to ed33655 Compare October 13, 2025 06:16
@Ovgodd Ovgodd merged commit ed33655 into main Oct 13, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/1308-replace-embedding-logo branch October 13, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Icon / Logo replaceable by NOT embedding it. Use <img> with URL instead.

2 participants