Repository navigation
✨(frontend) link to create new doc - #1574
Conversation
be4a72e to
0ceb0cd
Compare
0ceb0cd to
87930ed
Compare
87930ed to
c9af2a5
Compare
|
Hey @rouja |
6cbf7ed to
3376146
Compare
|
Size Change: +2.86 kB (+0.07%) Total Size: 4.11 MB
|
|
🚀 Preview will be available at https://1574-docs.ppr-docs.beta.numerique.gouv.fr/ You can use the existing account with these credentials:
You can also create a new account if you want to. Once this Pull Request is merged, the preview will be destroyed. |
@virgile-dev All good, you can try again. |
virgile-dev
left a comment
There was a problem hiding this comment.
hey @AntoLC nice job !
It works really nicely.
Only issues I've encountered are when the user is not loggued in.
A doc is created on the callback but url params seem to be lost.
For ex :
- user not loggued in enters this url https://1574-docs.ppr-docs.beta.numerique.gouv.fr/docs/new/?title=quetal&link-reach=authenticated&link-role=reader
- 401
- Click on login
- Redirect to a private doc without a title
It's weird to be redirected to 401 on step 2 cause technically the doc shouldn't be created until the user is loggued in. So a redirect to the auth page directly would make more sense.

We create a special URL to create a new doc, we can set the doc with the URL param to set the visibility, the permission and the title.
3376146 to
7475b7c
Compare
Yes you're right. I improved this process, can you give it a try again ? Now, if not logged, I redirect directly to the login page, when you come back I replay the url. |
virgile-dev
left a comment
There was a problem hiding this comment.
Much butter congrats !
Purpose
We create a special URL to create a new doc, we can set the doc with the URL param to set the visibility, the permission and the title.
Possibilities