Skip to content

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Nov 18, 2025

Purpose

Fix accessibility issue where screen readers cannot identify the purpose of buttons in the document sharing modal.

issue : 1619

Proposal

  • Add aria-label to remove member button with user's name.
  • Add descriptive aria-label to invite button indicating who/how many will be invited
  • Ensure all interactive elements are properly announced by screen readers

@Ovgodd Ovgodd requested a review from AntoLC November 18, 2025 13:36
@Ovgodd Ovgodd self-assigned this Nov 18, 2025
@Ovgodd Ovgodd changed the title ♿(a11y) improve share modal button accessibility ♿(frontend) improve share modal button accessibility Nov 18, 2025
@Ovgodd Ovgodd force-pushed the fix/a11y-inv-remove-aria-label branch 2 times, most recently from b10765d to 78d1fe9 Compare November 18, 2025 13:39
@Ovgodd Ovgodd marked this pull request as ready for review November 18, 2025 13:40
@Ovgodd Ovgodd linked an issue Nov 18, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Size Change: +76 B (0%)

Total Size: 4.07 MB

Filename Size Change
apps/impress/out/_next/static/c29a85d3/_buildManifest.js 0 B -883 B (removed) 🏆
apps/impress/out/_next/static/76640c8f/_buildManifest.js 883 B +883 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/a11y-inv-remove-aria-label branch 2 times, most recently from 7be2b54 to 01305ec Compare November 18, 2025 15:41
Added aria-labels to remove and invite buttons

Signed-off-by: Cyril <[email protected]>
@Ovgodd Ovgodd force-pushed the fix/a11y-inv-remove-aria-label branch from 01305ec to 26620f3 Compare November 20, 2025 07:28
@Ovgodd Ovgodd merged commit 26620f3 into main Nov 20, 2025
22 of 23 checks passed
@Ovgodd Ovgodd deleted the fix/a11y-inv-remove-aria-label branch November 20, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A11y: Invite/Remove member buttons need accessible names

3 participants