♿(frontend) improve screen reader support in DocShare modal with aria… #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/a11y-improve-doc-share-sr
branch
from
f0a76cc to
b3e403d
Compare
Ovgodd
force-pushed
the
fix/a11y-improve-doc-share-sr
branch
3 times, most recently
from
a82b0a3 to
5d6ade1
Compare
|
Size Change: +258 B (+0.01%) Total Size: 4.07 MB
|
Ovgodd
force-pushed
the
fix/a11y-improve-doc-share-sr
branch
from
5d6ade1 to
9f5ed00
Compare
adds relevant aria-labels to enhance accessibility for assistive technologies Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/a11y-improve-doc-share-sr
branch
from
9f5ed00 to
1a5281b
Compare
AntoLC
reviewed
Nov 20, 2025
Comment on lines
+215
to
+222
| style={{ | ||
| position: 'absolute', | ||
| left: '-10000px', | ||
| width: '1px', | ||
| height: '1px', | ||
| overflow: 'hidden', | ||
| }} | ||
| > |
Collaborator
There was a problem hiding this comment.
The style attach with sr-only is not enough ?
Comment on lines
+93
to
105
| // Announce to screen readers | ||
| const userName = user.full_name || user.email; | ||
| setLiveAnnouncement( | ||
| t( | ||
| '{{name}} added to invite list. Add more members or press Tab to select role and invite.', | ||
| { | ||
| name: userName, | ||
| }, | ||
| ), | ||
| ); | ||
| // Clear announcement after it's been read | ||
| setTimeout(() => setLiveAnnouncement(''), 100); | ||
| }; |
Collaborator
There was a problem hiding this comment.
I find a bit strange to do the announcement, we have a notification system, but I think we decided to not display a notification for that, because the invitation list will display the user that you just add, it is already like a announcement.
| - ♿(frontend) improve ARIA in doc grid and editor for a11y #1519 | ||
| - ♿(frontend) improve accessibility and styling of summary table #1528 | ||
| - ♿(frontend) add focus trap and enter key support to remove doc modal #1531 | ||
| - ♿(frontend) improve screen reader support in DocShare modal #1628 |
Collaborator
There was a problem hiding this comment.
During rebase, this part will have to go under Unrelease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve accessibility in the DocShare modal by enhancing screen reader support.
this fix this issue too
Proposal
ariaLabelprop toDocRoleDropdownfor contextual role change labelsariaLabelinDocShareAccessRequest,Invitation, andMemberitemsDocShareModalfor: