馃悰(nginx) fix 404 when accessing a doc - #866
Merged
Merged
Conversation
Member
|
I think it can also tested using tilt. |
AntoLC
force-pushed
the
fix/nginx-404
branch
3 times, most recently
from
April 22, 2025 11:22
436819b to
09e3489
Compare
lunika
approved these changes
Apr 28, 2025
We improve the nginx way to access to a specific doc. We stop to wait for a initial attempt that give a 404. If we see a UUID in the url we will redirect to the doc/[id] page. Next will then manage the 404.
The keycloak configuration used in dev environment is too generic and we can have a conflict with other project that are using the same ingress domain. Also the namespace was missing in the keycloak extra ConfigMap leading to creating it in the default namespace.
This was referenced May 2, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We improve the nginx way to access to a specific doc, to not have a 404 before accessing the resource.
Proposal
We stop to wait for a initial attempt that give a 404.
If we see a UUID in the url we will redirect to the doc/[id] page.
Nextwill then manage the 404.Easy way to test
src/frontend/apps/impressyarn builddocker-compose.yml, add this service:http://localhost:3000