Repository navigation
🔒(frontend) enhance file download security - #889
Merged
Merged
Conversation
NathanVss
approved these changes
Apr 18, 2025
NathanVss
left a comment
NathanVss
left a comment
Contributor
There was a problem hiding this comment.
I approve now as it must pass as a hotfix. But imo we should add all the tests cases that clear the OWASP recommendations
lunika
approved these changes
Apr 18, 2025
lunika
left a comment
lunika
left a comment
Member
There was a problem hiding this comment.
Can you update the changelog please
PanchoutNathan
force-pushed
the
fix/xss-file-download-button
branch
5 times, most recently
from
April 23, 2025 06:50
bb10b34 to
f8bd2ce
Compare
Added a safety check for URLs in the FileDownloadButton component. Now, before opening a URL, it verifies if the URL is safe using the isSafeUrl function. This prevents potentially unsafe URLs from being opened in a new tab
lunika
force-pushed
the
fix/xss-file-download-button
branch
from
April 28, 2025 12:37
f8bd2ce to
85b699a
Compare
lunika
enabled auto-merge (squash)
April 28, 2025 12:37
This was referenced May 2, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Added a safety check for URLs in the FileDownloadButton component. Now, before opening a URL, it verifies if the URL is safe using the isSafeUrl function.
This prevents potentially unsafe URLs from being opened in a new tab.