preventing chrome error when highlight cue called #2853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Mar 27, 2025
|
|
||
| highlightCue(evt) { | ||
| // This method is called when the time-updated event is triggered | ||
| // In Chrome, the event may be called even before the player is loaded |
Contributor
There was a problem hiding this comment.
can you be more specific about what you mean by "the player"?
Contributor
There was a problem hiding this comment.
Is it possible this happens if the video starts before we have the vtt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2335
What this pull request does:
In Chrome, the method for highlightCues is being called even before the player has fully loaded. (This may be due to some code that seems to be copying properties over which leads a timeupdate event being triggered. Code copied below from the Chrome debugger). This pull request adds code that returns from the method without doing anything if the player has not been loaded.
Reference:
/**
crossOriginfrom the media element.crossOriginindicates*/
'crossOrigin'].forEach(function (prop) {
Html5.prototype['set' + toTitleCase$1(prop)] = function (v) {
this.el_[prop] = v;
};
});