use height/width variables in iframe #2948
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Oct 24, 2025
|
|
||
| def width | ||
| embed_request.maxwidth | ||
| embed_request.maxwidth || default_width |
Contributor
There was a problem hiding this comment.
The width attribute of an iframe element in HTML expects a valid positive integer representing the width in CSS pixels. It does not directly support percentage units.
Contributor
Author
There was a problem hiding this comment.
I tried it both with and without and it worked with 100%. When it wasn't set it went to 300px with width 100% it stretch the screen.
Contributor
Author
There was a problem hiding this comment.
This suggests that it is valid: https://html.com/attributes/iframe-width/ but not recommended. We can have an another conversation about fixing this in Mirador and Spotlight but it would require use to touch two code bases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2945