코드 리뷰

page/__init__.py

@@ -0,0 +1,2 @@
+# TODO: 왜 __init__.py 파일이 필요한지 주석으로라도 적어주세요.
+# 필요 없다면 지우는 편이 좋을 거 같습니다.

page/admin.py

@@ -3,4 +3,4 @@
 
 
 # Register your models here.
-admin.site.register(Post)
+admin.site.register(Post)

page/models.py

@@ -3,11 +3,13 @@
 from django.conf import settings
 
 # Create your models here.
+
+
 class Post(models.Model):
     title = models.CharField(max_length=50, default='')
     update_date = models.DateTimeField(default=timezone.now)
     text = models.TextField()
-    image = models.ImageField(upload_to = 'images/', blank = True, null = True)
+    image = models.ImageField(upload_to='images/', blank=True, null=True)
 
     def __str__(self):
-        return self.title
+        return self.title

page/urls.py

@@ -2,10 +2,10 @@
 from . import views
 
 urlpatterns = [
-    path('', views.home, name = 'home'),
-    path('post/<int:post_id>', views.detail, name = 'detail'),
-    path('new/', views.new, name = 'new'),
-    path('create/', views.create, name = 'create'),
-    path('update/<int:post_id>', views.update, name = 'update'),
-    path('delete/<int:post_id>', views.delete, name = 'delete'),
-]
+    path('', views.home, name='home'),
+    path('post/<int:post_id>', views.detail, name='detail'),
+    path('new/', views.new, name='new'),
+    path('create/', views.create, name='create'),
+    path('update/<int:post_id>', views.update, name='update'),
+    path('delete/<int:post_id>', views.delete, name='delete'),
+]

page/views.py

@@ -2,17 +2,23 @@
 from .models import Post
 
 # Create your views here.
+# TODO: 각각의 view가 어떤 걸 의미하는지 Docstring으로 적어주세요.
+
+
 def home(request):
     posts = Post.objects.all()
-    return render(request, 'home.html', {'posts':posts})
+    return render(request, 'home.html', {'posts': posts})
+
 
 def detail(request, post_id):
-    post = get_object_or_404(Post, pk = post_id)
-    return render(request, 'detail.html', {'post':post})
+    post = get_object_or_404(Post, pk=post_id)
+    return render(request, 'detail.html', {'post': post})
+
 
 def new(request):
     return render(request, 'new.html')
 
+
 def create(request):
     if request.method == 'POST':
         post = Post()
@@ -24,9 +30,10 @@ def create(request):
         post.save()
 
         return redirect('detail', post.id)
-
+
+
 def update(request, post_id):
-    post = get_object_or_404(Post, pk = post_id)
+    post = get_object_or_404(Post, pk=post_id)
 
     if request.method == 'POST':
         if 'image' in request.FILES:
@@ -37,9 +44,10 @@ def update(request, post_id):
         post.save()
         return redirect('detail', post.id)
     else:
-        return render(request, 'update.html', {'post':post})
+        return render(request, 'update.html', {'post': post})
+
 
 def delete(request, post_id):
-    post = get_object_or_404(Post, pk = post_id)
+    post = get_object_or_404(Post, pk=post_id)
     post.delete()
     return redirect('home')

sullivanwiki/settings.py

@@ -2,6 +2,7 @@
 from pathlib import Path
 
 # Build paths inside the project like this: BASE_DIR / 'subdir'.
+# TODO: 각각의 설정이 어떤 것을 의미하는지 적어주세요.
 BASE_DIR = Path(__file__).resolve().parent.parent
 
 
@@ -117,4 +118,4 @@
 
 MEDIA_ROOT = os.path.join(BASE_DIR, 'media')
 
-MEDIA_URL = '/media/'
+MEDIA_URL = '/media/'

sullivanwiki/urls.py

@@ -7,4 +7,4 @@
 urlpatterns = [
     path('admin/', admin.site.urls),
     path('', include('page.urls')),
-] + static(settings.MEDIA_URL, document_root = settings.MEDIA_ROOT)
+] + static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)