Skip to content

Add early support for nested types (like struct and list<struct>) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

trueleo
Copy link

@trueleo trueleo commented Apr 30, 2025

Summary

This PR introduces early support for nested types, such as Struct and List, similar to those found in DataFusion. The primary goal is to explore and validate an approach for encoding these complex types.

Changes

  • Refactored encode_value to support recursion, enabling encoding of arbitrary nested types.
  • Initial handling logic for Struct and List types (not fully tested yet).

Note

I couldn't find any official information about what client's are suppose to accept. Struct binary encoding is based on the logic found here

@trueleo
Copy link
Author

trueleo commented May 7, 2025

@sunng87 Current integration test is not good enough to make sure this feature works. Do you have any ideas on how we can improve tests for this ?

Specifically testing for binary/text encoding and other features like information schema

@trueleo trueleo marked this pull request as ready for review May 7, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant