feat: linter suppressions #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

juleswritescode wants to merge 23 commits into main from feat/suppressions

Collaborator

juleswritescode commented Jul 3, 2025 •

edited

Loading

This makes it possible to suppress linting rules 👍🏻

They mostly work like biome's suppressions, except that you don't have to provide an explanation, and you can use multiple suppressions above a diagnostic:

-- pgt-ignore lint/safety/banDropNotNull
-- pgt-ignore lint/safety/banDropTable
<query causing both diagnostics>

~~We can't suppress type-check diagnostics yet, but I'd like to implement that in a future PR.~~
Suppressing typechecks and other diagnostics was easier than I thought, so I added it to this PR

Also, we need to add this to the docs – also future PR!

juleswritescode added 5 commits

June 25, 2025 09:12


          new crate

8a8b4c6


          feat: suppressions

3a0bd03

ok

4285e6a

ok

f33bc67


          fix(analyser): recognize disabled rules

bc704c1

juleswritescode marked this pull request as draft

July 3, 2025 06:36

juleswritescode added 10 commits

July 3, 2025 08:37


          merged

a2366a4

ok

9a793a8


          format

3b15864


          linting

4fa6de0


          comment, rename

792d14c


          clean up

7d79543


          add tests

eab166f

Ok

f60383f


          Merge branch 'main' of https://github.com/supabase-community/postgres…

38a6395

…_lsp into feat/suppressions

ok

647fd36

juleswritescode commented

View reviewed changes

crates/pgt_workspace/src/workspace/server.rs Outdated Show resolved Hide resolved

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/src/suppression.rs Show resolved Hide resolved

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/src/suppression.rs Show resolved Hide resolved

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/src/parser.rs Show resolved Hide resolved

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/src/lib.rs Outdated Show resolved Hide resolved

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/src/lib.rs Show resolved Hide resolved

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/Cargo.toml Outdated Show resolved Hide resolved

juleswritescode commented

View reviewed changes

Collaborator Author

juleswritescode left a comment

–

juleswritescode and others added 3 commits

July 5, 2025 09:45


          Update crates/pgt_suppressions/src/lib.rs

f4cb0ec


          no clone

d957bce


          Merge branch 'feat/suppressions' of https://github.com/supabase-commu…

f830d4d

…nity/postgres_lsp into feat/suppressions

juleswritescode requested a review from psteinroe

July 5, 2025 08:06

juleswritescode marked this pull request as ready for review

July 5, 2025 08:06

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/src/lib.rs Outdated Show resolved Hide resolved


          Update crates/pgt_suppressions/src/lib.rs

b8e00b5

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/src/lib.rs Outdated Show resolved Hide resolved


          Update crates/pgt_suppressions/src/lib.rs

0d77e52

juleswritescode commented

View reviewed changes

crates/pgt_suppressions/src/lib.rs Outdated Show resolved Hide resolved

juleswritescode and others added 3 commits

July 5, 2025 10:09


          Update crates/pgt_suppressions/src/lib.rs

4b73bed


          feat(suppressions): suppress all kinds of diagnostics (#442)

59aa3f1


          fix tests

8d1bd8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet