Skip to content

refactor: extract completions context into pgt_treesitter crate #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ pgt_suppressions = { path = "./crates/pgt_suppressions", version = "0.
pgt_text_edit = { path = "./crates/pgt_text_edit", version = "0.0.0" }
pgt_text_size = { path = "./crates/pgt_text_size", version = "0.0.0" }
pgt_tokenizer = { path = "./crates/pgt_tokenizer", version = "0.0.0" }
pgt_treesitter_queries = { path = "./crates/pgt_treesitter_queries", version = "0.0.0" }
pgt_treesitter = { path = "./crates/pgt_treesitter", version = "0.0.0" }
pgt_typecheck = { path = "./crates/pgt_typecheck", version = "0.0.0" }
pgt_workspace = { path = "./crates/pgt_workspace", version = "0.0.0" }

Expand Down
23 changes: 11 additions & 12 deletions crates/pgt_completions/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,17 @@ version = "0.0.0"
[dependencies]
async-std = "1.12.0"

pgt_text_size.workspace = true


fuzzy-matcher = "0.3.7"
pgt_schema_cache.workspace = true
pgt_treesitter_queries.workspace = true
schemars = { workspace = true, optional = true }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
tracing = { workspace = true }
tree-sitter.workspace = true
tree_sitter_sql.workspace = true
pgt_schema_cache.workspace = true
pgt_text_size.workspace = true
pgt_treesitter.workspace = true

fuzzy-matcher = "0.3.7"
schemars = { workspace = true, optional = true }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
tracing = { workspace = true }
tree-sitter.workspace = true
tree_sitter_sql.workspace = true

sqlx.workspace = true

Expand Down
7 changes: 4 additions & 3 deletions crates/pgt_completions/src/builder.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
use crate::{
CompletionItemKind, CompletionText,
context::CompletionContext,
item::CompletionItem,
relevance::{filtering::CompletionFilter, scoring::CompletionScore},
};

use pgt_treesitter::TreesitterContext;

pub(crate) struct PossibleCompletionItem<'a> {
pub label: String,
pub description: String,
Expand All @@ -17,11 +18,11 @@ pub(crate) struct PossibleCompletionItem<'a> {

pub(crate) struct CompletionBuilder<'a> {
items: Vec<PossibleCompletionItem<'a>>,
ctx: &'a CompletionContext<'a>,
ctx: &'a TreesitterContext<'a>,
}

impl<'a> CompletionBuilder<'a> {
pub fn new(ctx: &'a CompletionContext) -> Self {
pub fn new(ctx: &'a TreesitterContext) -> Self {
CompletionBuilder { items: vec![], ctx }
}

Expand Down
21 changes: 13 additions & 8 deletions crates/pgt_completions/src/complete.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
use pgt_text_size::TextSize;

use pgt_treesitter::{TreeSitterContextParams, context::TreesitterContext};

use crate::{
builder::CompletionBuilder,
context::CompletionContext,
item::CompletionItem,
providers::{
complete_columns, complete_functions, complete_policies, complete_roles, complete_schemas,
Expand All @@ -28,16 +29,20 @@ pub struct CompletionParams<'a> {
pub fn complete(params: CompletionParams) -> Vec<CompletionItem> {
let sanitized_params = SanitizedCompletionParams::from(params);

let ctx = CompletionContext::new(&sanitized_params);
let ctx = TreesitterContext::new(TreeSitterContextParams {
position: sanitized_params.position,
text: &sanitized_params.text,
tree: &sanitized_params.tree,
});

let mut builder = CompletionBuilder::new(&ctx);

complete_tables(&ctx, &mut builder);
complete_functions(&ctx, &mut builder);
complete_columns(&ctx, &mut builder);
complete_schemas(&ctx, &mut builder);
complete_policies(&ctx, &mut builder);
complete_roles(&ctx, &mut builder);
complete_tables(&ctx, sanitized_params.schema, &mut builder);
complete_functions(&ctx, sanitized_params.schema, &mut builder);
complete_columns(&ctx, sanitized_params.schema, &mut builder);
complete_schemas(&ctx, sanitized_params.schema, &mut builder);
complete_policies(&ctx, sanitized_params.schema, &mut builder);
complete_roles(&ctx, sanitized_params.schema, &mut builder);

builder.finish()
}
1 change: 0 additions & 1 deletion crates/pgt_completions/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
mod builder;
mod complete;
mod context;
mod item;
mod providers;
mod relevance;
Expand Down
Loading