Partial ABI compatibility validation implementation#1164
Open
sproctor wants to merge 1 commit into
Open
Conversation
Collaborator
|
Yea looks good to me at first glance. |
Contributor
Author
|
Technically, yes, they are relevant. If they're called from an inline function, then they need to be kept. If they're just called from another module, then I think that's an ABI breaking change that is ok, because I don't think supporting mixed versions of modules is worthwhile. Probably best to include them in the API anyway so any changes are intentional. I'm a bit overwhelmed with other work right now. It might take me a week or two to get back to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Very incomplete implementation of using Kotlin's ABI compatibility validation plugin. Before I went to implement this, I wanted to get your thoughts.
This could go in
buildSrcand be applied to each module that should maintain ABI compatibility.Motivation
While contemplating some changes that would change the ABI, I thought it might be good to have a validation procedure in place.