-
Notifications
You must be signed in to change notification settings - Fork 431
fix: define search path in auth functions #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't inspected it in detail, but can we have a test making sure we're not breaking things the same way as the last time this was attempted?
Also @kangmingtay can we run an inspection script to see if people have changed grants on these functions. If we do |
Pull Request Test Coverage Report for Build 9659049953Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9659133962Details
💛 - Coveralls |
@kangmingtay is this something we still want to do, or can we close it? |
What kind of change does this PR introduce?
auth.uid()
andauth.role()
function to account for the change in postgres 14, which made this impossible:current_setting(
request.jwt.claim.my-claim, true)
(thus always returning null), so we need to also includecurrent_setting('request.jwt.claims', true), '')::jsonb ->> 'sub'
(note the s in claims)