Skip to content

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Aug 25, 2025

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Avoids bill shock when user accidentally enables paid addons from config push.

Additional context

...
Enabling Advanced MFA - Phone will cost you $75/month, then $10/month. Keep it enabled? [Y/n] n
Enabling Advanced MFA - WebAuthn will cost you $75/month, then $10/month. Keep it enabled? [Y/n] n
Updating Auth service with config: diff remote[auth] local[auth]
--- remote[auth]
+++ local[auth]

@sweatybridge sweatybridge requested a review from a team as a code owner August 25, 2025 10:26
Copy link
Member

@avallete avallete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

FMI how does it work for branches ? Enabling those for branches does also incurs extra cost on top of the project ? Is it included ?

I'm wondering if a user might mistakingly activate the options on every branches just because it use a single config.toml between branching/prod 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants