Upstream changes from Aspen Cloud #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update package.json
sweatybridge
reviewed
Oct 1, 2025
sweatybridge
left a comment
sweatybridge
left a comment
There was a problem hiding this comment.
Apart from regenerating types and new gql client methods, this PR adds the following functionality
- supports
fly-machine-lease-nonceheader in updateMachine - supports
deleteLeaseoperation
Did I miss anything?
| async getAppDetailed( | ||
| app_name: GetAppRequest | ||
| ): Promise<APIResponse<AppDetailedResponse>> { | ||
| const response = await this.client.safeGqlPost<string, { app: any }>({ |
There was a problem hiding this comment.
Can we avoid typing app: any in calls to safeGqlPost? Always define the interface types returned from graphql api call.
| async listMachines(app_name: ListMachineRequest): Promise<MachineResponse[]> { | ||
| async listMachines( | ||
| app_name: ListMachineRequest | ||
| ): Promise<APIResponse<MachineResponse[]>> { |
There was a problem hiding this comment.
What's the reason for wrapping errors in the response object instead of throwing? This would be a breaking change for existing users of this library which I'd like to avoid.
A few other options
- create another wrapper class
- bump the major version
Co-authored-by: Han Qiao <[email protected]>
Co-authored-by: Han Qiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This brings in some of the changes we used at Aspen Cloud to run Triplit Cloud. We used these changes (in our own fork) in production to deploy, update, and manage applications and machines on Fly.
Changes