chore: use literal for limits and offsets#1075
Conversation
b48436c to
f90f82b
Compare
avallete
left a comment
There was a problem hiding this comment.
We do the escaping for filterByValue and filterByList even tough at the end of the day postgres-meta is meant to execute queries on database that the user already has access to.
Since the pattern is so similar everywhere, we might consider normalizing this into an helper. That can be done as a follow-up tough.
💯 agree, there are some endpoints though that have unexpected side effects, for example config.sql.ts can be called as: Pipeline-ing the |
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Limits and offsets are typed as Number but are treated as string in SQL template generation
What is the new behavior?
Treats these as literals so the SQL will always be correct / valid.
Additional context
Add any other context or screenshots.