fix(typegen): use javascript deterministic sort for args join#930
Merged
fix(typegen): use javascript deterministic sort for args join#930
Conversation
Pull Request Test Coverage Report for Build 14363335713Details
💛 - Coveralls |
soedirgo
reviewed
Apr 10, 2025
| }) | ||
| return `{ ${argsNameAndType.map(({ name, type, has_default }) => `${JSON.stringify(name)}${has_default ? '?' : ''}: ${type}`)} }` | ||
| }) | ||
| .toSorted() |
soedirgo
approved these changes
Apr 10, 2025
avallete
added a commit
that referenced
this pull request
May 13, 2025
fix(typegen): use javascript deterministic sort for args join
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Should resolve: #929