Conversation
1904a35 to
1d91784
Compare
Pull Request Test Coverage Report for Build 16450960387Details
💛 - Coveralls |
3c757e7 to
d4c173d
Compare
987481f to
7e303c8
Compare
fenos
approved these changes
Jun 27, 2025
7e303c8 to
bd49271
Compare
bd49271 to
25fda8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When a bucket is emptied it sends
DeleteObjectsCommandto S3 in a tight loop resulting in rate limit errors and ultimately orphan objects.What is the new behavior?
Use the queue to delete objects from the underlying object store asynchronously
Additional context
This adds
ObjectDeleteAllBeforeEventwhich recursively removes all objects before a specified time in batches usingstorage.backend.deleteObjects(...)within a transaction so the database objects will be rolled back if the S3 operation fails.Each job run removes as many batches as it can in 10 seconds and then re-queues if there are remaining objects to delete.