feat: add missing HTTP headers for client platform and runtime detection #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add X-Supabase-Client-Platform header with platform detection (macOS, Windows, Linux, iOS, Android) - Add X-Supabase-Client-Platform-Version header with OS version detection - Add X-Supabase-Client-Runtime header with runtime detection (node, deno, bun, web) - Add X-Supabase-Client-Runtime-Version header with runtime version detection - Add comprehensive unit tests for all new header functionality - Maintain backward compatibility with existing X-Client-Info header 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove regex pattern matching for platform/runtime version detection - Only include headers when platform/runtime can be reliably detected - Return null instead of 'unknown' when detection fails - Simplify platform detection to only handle exact matches - Update tests to handle conditional header presence - Maintain backward compatibility with X-Client-Info header 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Pull Request Test Coverage Report for Build 16300970139Details
💛 - Coveralls |
…t Client Hints API - Replace deprecated navigator.platform with navigator.userAgentData - Use navigator.userAgentData.platform for platform detection - Use navigator.userAgentData.platformVersion for version detection - Maintain backward compatibility with process.platform for Node.js - All tests continue to pass with new implementation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing HTTP headers for client platform and runtime detection with simplified logic that only includes headers when detection is reliable.
New Headers Added
X-Supabase-Client-Platform: OS detection (macOS, Windows, Linux, iOS, Android)X-Supabase-Client-Platform-Version: Platform versionX-Supabase-Client-Runtime: Runtime environment (node, deno, bun)X-Supabase-Client-Runtime-Version: Runtime versionKey Features
X-Client-InfoheaderTest plan
🤖 Generated with Claude Code