fix: concurrency warnings pre swift 6 support #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
force-pushed
the
fix/concurrency-warnings
branch
from
a4befbf
to
4ad9673
Compare
dshukertjr
approved these changes
Jun 28, 2024
|
I tried the new version, but this change seems to have broken the API completely. Swift.DecodingError.dataCorrupted(Swift.DecodingError.Context(codingPath: [_JSONKey(stringValue: "Index 0", intValue: 0), CodingKeys(stringValue: "created_at", intValue: nil)], debugDescription: "Invalid date format: 2024-06-15T18:12:04+00:00", underlyingError: nil)) Although the date string in the error output seems to be OK. I'm using Xcode 15.4, with Swift 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is part of the Swift 6 mode support, some concurrency warnings will become errors when Swift 6 is enabled.
This PR fixes a couple of concurrency warnings, by not using the
ISO8601DateFormatter, which isn'tSendablein favor of theDateFormatter, which isSendableand is already being used on some places