Validate map url for agenda printing#1522
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens agenda-item print rendering by validating the map URL query parameter server-side and removing unsafe template rendering to reduce XSS risk when embedding the static map image.
Changes:
- Add a
mapURL validator toAgendaItemParamsthat enforces a Google Static Maps prefix and a parameter allowlist. - Remove the Jinja
| safefilter and quote thesrcattribute when rendering the map image. - Add tests covering accepted map rendering and rejection of invalid prefixes/characters/parameters.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/core/test_agenda.py | Adds print/map rendering and validator rejection tests. |
| newsroom/templates/agenda_item_print.html | Removes safe usage and quotes src to rely on autoescaping. |
| newsroom/agenda/views.py | Introduces map URL validation/normalization and allowlisted query parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
petrjasek
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Validates the map URL passed on printing to prevent XSS vulnerability
What has changed
Addition of a Validation function on the passed map parameter, also remove the "safe" from the jinja template variable usage.
Steps to test
Ensure that the printed event include a map if enabled.
Checklist
lodash.getwith optional chaining for modified code segmentsResolves: #SDAN-769