-
-
Notifications
You must be signed in to change notification settings - Fork 545
Updated to use new apis #4681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master_27
Are you sure you want to change the base?
Updated to use new apis #4681
Conversation
…rent extruder count
…s, setting converter.
|
I merged my changes with the new superslicer version so its up to date. Everything is working and compilling but there may be some redundand or obsolete code (i havent checked all of the files it merged into) |
|
Thanks. |
|
Thank you for pointing this out to me. The builds revealed that compilling SuperSlicer works fine on all different os`s but building the deps fails. Ill look into it |
|
Ah, i found the issue. Its because in the new version, i removed all the folders from the bundled in dependencies that i was able to outsource to use the system dependencies. The git build probaply still whants to use the build in boost so because there is non anymore it fails. This is probaply a failure from the gitbuild side (All windows, linux and mac fail with the same error in deps and on my machine locally all the deps compile fine, on linux as well as on windows). Sadly, i have no clue about yml and git builds, so i probaply whont be able to rewrite it. |
|
I confirmed it. Because i made cmake use systemlibs instead of the ones in the source, the yml git build files have to be modified for that |
you don't need to modify yml, the yml just call BuildLinux.sh or BuildMacos.sh but as you deleted note: you don't want to commit |
|
Ah, ok ill remove the cmake/CPackConfig.cmake then. Could you maybe verify if it builds on windows (the deps too)? It works on my machine but i still cant get it working in the github builds. The issue is not the flag that i added, but that the enviroments on github dont have the required system libs installed, and homebrew installs them without cmake support which is needed. |
|
I fixed the build dep issue now, but its still failing in the main phase now. Ill fix it soon hopefully |
|
There is a small issue with github using .a instead of .so for some dependencies, ill try to resolve it as soon as possible |
74da518 to
1f3d287
Compare
I updated SuperSlicer to use the new apis of some of its dependencies and changed some to use the system wide ones instead of the bundled ones.