Open
Conversation
…field renderers Add fixedOverflowWidgets: true to editor options in TextFieldRenderer, ObjectFieldRenderer, and XMLFieldRenderer. This tells Monaco to render overlay widgets (autocomplete/suggest dropdown) in a fixed-position container that escapes overflow:hidden ancestors, preventing the suggestion dropdown from being clipped by the component sidebar.
|
👋 Commands for maintainers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1804 — The autocomplete/suggestions dropdown in Monaco editor input fields was being cropped/clipped when used inside the component configuration sidebar.
Root Cause
The component sidebar (
componentSidebar/index.tsx) usesoverflow-hiddenon its container, which clips any child elements that extend beyond its boundaries. Monaco's suggest widget (autocomplete dropdown) is rendered inside the editor's DOM tree by default, so it gets cut off by the sidebar's overflow clipping.Fix
Added
fixedOverflowWidgets: trueto the Monaco editor options in all three configuration field renderers:This is Monaco's built-in solution for this exact problem — it renders overlay widgets (like the autocomplete dropdown, parameter hints, etc.) in a fixed-position container that escapes
overflow: hiddenancestors.Changes
web_src/src/ui/configurationFieldRenderer/TextFieldRenderer.tsxfixedOverflowWidgets: trueto editor optionsweb_src/src/ui/configurationFieldRenderer/ObjectFieldRenderer.tsxfixedOverflowWidgets: trueto editor optionsweb_src/src/ui/configurationFieldRenderer/XMLFieldRenderer.tsxfixedOverflowWidgets: trueto editor optionsVerification
tsc --noEmitpasses)npm run buildpasses)make format.jspasses)