fix: Add PagerDuty pagination for ListServices, ListUsers, ListEscalationPolicies, and ListIncidents methods#3866
Open
NickDub wants to merge 2 commits intosuperplanehq:mainfrom
Open
Conversation
|
👋 Commands for maintainers:
|
NickDub
force-pushed
the
fix/pagerduty-pagination
branch
from
17c510e to
c68c683
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
NickDub
force-pushed
the
fix/pagerduty-pagination
branch
4 times, most recently
from
48227fb to
6332425
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
NickDub
force-pushed
the
fix/pagerduty-pagination
branch
5 times, most recently
from
92dab5e to
6364280
Compare
NickDub
changed the title
NickDub
force-pushed
the
fix/pagerduty-pagination
branch
3 times, most recently
from
6ee04ee to
bc49429
Compare
…es, and ListIncidents methods Signed-off-by: Nicolas Dubois <nicolas.dubois@adeo.com>
Signed-off-by: Nicolas Dubois <nicolas.dubois@adeo.com>
NickDub
force-pushed
the
fix/pagerduty-pagination
branch
from
bc49429 to
b5a096f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3884
The ListServices, ListUsers, ListEscalationPolicies, and ListIncidents methods return only the first 25 values (default number of items).
Changes
This PR implements the pagination for ListServices, ListUsers, ListEscalationPolicies, and ListIncidents methods for PagerDuty Integration to retrieve all the values.