feat: add grafana alert control#3897
Open
WashingtonKK wants to merge 4 commits intosuperplanehq:mainfrom
Open
Conversation
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
|
👋 Commands for maintainers:
|
superplane-policy-bot
bot
requested review from
forestileao,
lucaspin and
shiroyasha
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| eventId: execution.rootEvent?.id || "", | ||
| }, | ||
| ]; | ||
| } |
Contributor
There was a problem hiding this comment.
Identical mapper boilerplate duplicated across four new files
Low Severity
The props, baseEventSections, metadataList, and subtitle implementations are copy-pasted identically across all four new mapper files. Other integrations in this codebase (e.g., cloudflare/base.ts, claude/base.ts) extract shared mapper logic into a common base module. A shared Grafana base file would eliminate the duplication and reduce the risk of inconsistent fixes later.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: #3885
This expands the Grafana integration by adding the following alert control components:
Demo Video
Note
Medium Risk
Adds new Grafana Alertmanager silence management API calls and workflow components, which can directly suppress alerts and relies on correct HTTP paths/payloads and time handling. Risk is moderate due to new external API surface and potential operational impact if misconfigured.
Overview
Adds Grafana Alertmanager silence control to workflows via four new actions:
grafana.listSilences,grafana.getSilence,grafana.createSilence, andgrafana.deleteSilence.Backend changes extend the Grafana client with silence models plus
ListSilences/GetSilence/CreateSilence/DeleteSilencemethods (including create-response ID parsing and permissive delete semantics), and introduce new component implementations with input validation and time parsing/ordering checks.Updates docs and embedded example outputs for the new actions, expands the integration’s token description, and wires up new workflow UI mappers/types and event-state registries so executions render relevant silence metadata.
Written by Cursor Bugbot for commit e5d07bd. This will update automatically on new commits. Configure here.