fix: harden canvas node rendering and workflow mapper preparation by forestileao · Pull Request #3899 · superplanehq/superplane

forestileao · 2026-04-01T18:10:02Z

Summary

make workflowv2 node preparation resilient to mapper, additional-data, and custom-field failures
isolate canvas node render failures so a single broken node no longer breaks the whole canvas
extract workflowv2 node-preparation and canvas block logic into smaller utilities/modules

What Changed

added safe wrappers for additional-data builders and custom-field renderers
normalized malformed mapper output before it reaches ComponentBase and Trigger
moved trigger, component, composite, annotation, and group node preparation into dedicated workflowv2 lib files
added per-node error boundaries in CanvasPage
replaced the monolithic Block.tsx with a Block/ module split into index, types, content, data, and handles
made Block fall back safely for malformed or unknown node data instead of throwing
hardened componentBase against invalid arrays, invalid strings, and custom field render errors
added regression tests for safe mappers, workflow node preparation, block fallback rendering, and canvas node isolation

superplanehq-integration · 2026-04-01T18:10:05Z

👋 Commands for maintainers:

/sp start - Start an ephemeral machine (takes ~30s)
/sp stop - Stop a running machine (auto-executed on pr close)

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/pages/workflowv2/mappers/index.ts

web_src/src/pages/workflowv2/lib/canvasNodePreparation.ts

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/pages/workflowv2/lib/canvas-annotation-node.ts

web_src/src/pages/workflowv2/lib/canvasNodeFallback.ts

web_src/src/ui/CanvasPage/index.tsx

web_src/src/ui/CanvasPage/Block/handles.tsx

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/pages/workflowv2/lib/canvas-node-preparation.ts

web_src/src/pages/workflowv2/lib/canvas-groups.ts

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/ui/CanvasPage/index.tsx

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/ui/CanvasPage/index.tsx

web_src/src/pages/workflowv2/lib/render-workflow-node-custom-field.ts

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/ui/CanvasPage/index.tsx

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/pages/workflowv2/mappers/safeMappers.ts

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/pages/workflowv2/lib/canvas-node-preparation.ts

web_src/src/pages/workflowv2/mappers/safeMappers.ts

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

web_src/src/pages/workflowv2/mappers/safeMappers.ts

web_src/src/ui/CanvasPage/Block/handles.tsx

web_src/src/ui/CanvasPage/Block/data.ts

web_src/src/pages/workflowv2/lib/canvas-node-preparation.ts

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

web_src/src/lib/records.ts

shiroyasha · 2026-04-02T11:16:32Z

web_src/src/lib/canvas-node-fallback.ts

@@ -0,0 +1 @@
+export const CANVAS_NODE_FALLBACK_MESSAGE = "Can't display";


Weird that we have a dedicated file for this and not for other files. Why?

shiroyasha · 2026-04-02T11:23:06Z

IMHO, there are too many changes for this one pull-request to be able to provide high-quality feedback.

It is ok now, the code generally looks ok, but looking at this list, every one of them would be self-sufficient for its own PR:

added safe wrappers for additional-data builders and custom-field renderers
normalized malformed mapper output before it reaches ComponentBase and Trigger
moved trigger, component, composite, annotation, and group node preparation into dedicated workflowv2 lib files
added per-node error boundaries in CanvasPage
replaced the monolithic Block.tsx with a Block/ module split into index, types, content, data, and handles
made Block fall back safely for malformed or unknown node data instead of throwing
hardened componentBase against invalid arrays, invalid strings, and custom field render errors
added regression tests for safe mappers, workflow node preparation, block fallback rendering, and canvas node isolation

forestileao · 2026-04-02T12:27:51Z

@shiroyasha I don;t think we need that level of granularity because some changes depend on other's. But i am going to split this PR in more.
Closing by now

## Summary - Add safe wrapper functions (`createSafeAdditionalDataBuilder`, `createSafeCustomFieldRenderer`) and normalization (`normalizeComponentBaseProps`, `normalizeTriggerProps`) so all mapper output is sanitized before reaching the canvas - Extract `findRegisteredComponentMapper` private helper to deduplicate component lookup logic - Add shared `@/lib/records` type guard utility and `@/lib/canvas-node-fallback` fallback constant ## Context Split from #3899. This is PR 1/3 — adds the error-handling foundation at the data layer. PRs 2 and 3 depend on this. <img width="2752" height="1086" alt="image" src="https://github.com/user-attachments/assets/c8772f84-8c71-4428-a556-66cf9e0f61cc" /> --------- Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

## Summary - Extract `prepareTriggerNode`, `prepareCompositeNode`, `prepareComponentNode` from `index.tsx` into `lib/canvas-node-preparation.ts` - Extract annotation node preparation into `lib/canvas-annotation-node.ts` - Extract custom field rendering into `lib/render-workflow-node-custom-field.ts` - Add fallback node builders in `lib/canvas-node-fallback.ts` for graceful degradation - Rename `workflow-groups` to `canvas-groups` and add `prepareGroupNode` + `wireGroupParentChildRelationships` - Extract `CANVAS_BUNDLE_ICON_SLUG`/`CANVAS_BUNDLE_COLOR` constants into `lib/canvas-bundle.ts` - Net reduction of ~420 lines from `index.tsx` ## Context Split from #3899. This is PR 2/3, depends on #3916. Restructures the data preparation layer without changing behavior. --------- Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

## Summary - Split monolithic `Block.tsx` (413 lines) into `Block/` module: `types.ts`, `content.tsx`, `data.ts`, `handles.tsx`, and `index.tsx` entry point - Add `CanvasNodeErrorBoundary` that catches per-node render errors, logs to Sentry, and displays a graceful fallback instead of crashing the entire canvas - Harden `componentBase` with input validation (`safeArray`, `safeString`, wrapped customField calls) - Replace `any` types with `unknown` throughout `CanvasPage/index.tsx` ## Context Split from #3899. This is PR 3/3, depends on #3916. Independent of PR 2 (#3917). --------- Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

forestileao added 3 commits April 1, 2026 15:10

fix(workflowv2): harden node mapper preparation

658f4e0

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

fix(canvas): isolate block render failures

c021639

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

chore(ui): update eslint budget baseline

82a51b3

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

forestileao force-pushed the fix/nodes-errors-should-not-break-the-canvas branch from 5e3b9e6 to 82a51b3 Compare April 1, 2026 18:10

forestileao added 3 commits April 1, 2026 15:42

fix

f207e2b

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

Merge branch 'main' into fix/nodes-errors-should-not-break-the-canvas

90fb991

enforce a better message

c48f66b

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

forestileao marked this pull request as ready for review April 1, 2026 18:49

superplane-policy-bot bot requested review from lucaspin and shiroyasha April 1, 2026 18:49

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/pages/workflowv2/mappers/index.ts Show resolved Hide resolved

web_src/src/pages/workflowv2/lib/canvasNodePreparation.ts Outdated Show resolved Hide resolved

address issues

11bb12e

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

lucaspin reviewed Apr 1, 2026

View reviewed changes

web_src/src/pages/workflowv2/lib/canvas-annotation-node.ts Show resolved Hide resolved

lucaspin reviewed Apr 1, 2026

View reviewed changes

web_src/src/pages/workflowv2/lib/canvasNodeFallback.ts Outdated Show resolved Hide resolved

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/ui/CanvasPage/index.tsx Show resolved Hide resolved

superplane-policy-bot bot requested a review from lucaspin April 1, 2026 19:20

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/ui/CanvasPage/Block/handles.tsx Outdated Show resolved Hide resolved

forestileao added 4 commits April 1, 2026 16:31

refactor(workflowv2): rename lib files to kebab-case

d936794

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

fix(canvas): remove internal node name props

2f61c6a

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

refactor(canvas): dedupe default block wiring

c6f9b85

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

fix

476ab84

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

forestileao force-pushed the fix/nodes-errors-should-not-break-the-canvas branch from b626dc3 to 476ab84 Compare April 1, 2026 19:32

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/pages/workflowv2/lib/canvas-node-preparation.ts Show resolved Hide resolved

web_src/src/pages/workflowv2/lib/canvas-groups.ts Show resolved Hide resolved

address unused exports

5de6371

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/ui/CanvasPage/index.tsx Show resolved Hide resolved

prevent flood

93b4166

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/ui/CanvasPage/index.tsx Outdated Show resolved Hide resolved

web_src/src/ui/CanvasPage/index.tsx Outdated Show resolved Hide resolved

web_src/src/pages/workflowv2/lib/render-workflow-node-custom-field.ts Outdated Show resolved Hide resolved

address

398e840

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/ui/CanvasPage/index.tsx Show resolved Hide resolved

address

c272972

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/pages/workflowv2/mappers/safeMappers.ts Show resolved Hide resolved

address

b0c07e8

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

cursor bot reviewed Apr 1, 2026

View reviewed changes

web_src/src/pages/workflowv2/lib/canvas-node-preparation.ts Show resolved Hide resolved

web_src/src/pages/workflowv2/mappers/safeMappers.ts Show resolved Hide resolved

fix conflict

5efd0d4

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

cursor bot reviewed Apr 1, 2026

View reviewed changes

fix conflict

f656683

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>

cursor bot reviewed Apr 2, 2026

View reviewed changes

web_src/src/lib/records.ts Show resolved Hide resolved

shiroyasha reviewed Apr 2, 2026

View reviewed changes

forestileao closed this Apr 2, 2026

This was referenced Apr 2, 2026

fix: harden mappers with safe wrappers #3916

Merged

chore: extract node preparation into dedicated lib files #3917

Merged

fix: refactor Block component and add error boundaries #3918

Merged

		@@ -0,0 +1 @@
		export const CANVAS_NODE_FALLBACK_MESSAGE = "Can't display";

Conversation

forestileao commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Uh oh!

superplanehq-integration bot commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shiroyasha Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

shiroyasha commented Apr 2, 2026

Uh oh!

forestileao commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

forestileao commented Apr 1, 2026 •

edited

Loading