feat: drain active SSE streams before agent shutdown#3900
Open
0vertake wants to merge 3 commits intosuperplanehq:mainfrom
Open
feat: drain active SSE streams before agent shutdown#39000vertake wants to merge 3 commits intosuperplanehq:mainfrom
0vertake wants to merge 3 commits intosuperplanehq:mainfrom
Conversation
Track in-flight SSE streams with an ActiveStreamTracker so the agent service waits for them to finish when SIGTERM is received, instead of killing them mid-response. New requests during shutdown are rejected with HTTP 503. Configurable drain timeout via GRACEFUL_SHUTDOWN_TIMEOUT env var (default 300s). Signed-off-by: Milos Jovanovic <milosjovanovic519@gmail.com>
|
👋 Commands for maintainers:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Move tracker.acquire() into the request handler so the active count is visible to wait_for_drain() before the async generator starts lazily. Prevents a race where drain completes and closes resources while a response is still being set up. Signed-off-by: Milos Jovanovic <milosjovanovic519@gmail.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
If the generator is never iterated (e.g. ASGI cancellation between handler return and first __anext__), release() in the generator's finally block never runs. Wrap the acquire-to-return gap so release() is called on any failure. Signed-off-by: Milos Jovanovic <milosjovanovic519@gmail.com>
lucaspin
reviewed
Apr 1, 2026
| return _DEFAULT_DRAIN_TIMEOUT | ||
|
|
||
|
|
||
| class ActiveStreamTracker: |
Contributor
There was a problem hiding this comment.
This should be in a separate file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How it works