fix: prevent bulk import retry loop for duplicate external IDs - #1334
Open
bcbogdan wants to merge 1 commit into
Open
fix: prevent bulk import retry loop for duplicate external IDs#1334bcbogdan wants to merge 1 commit into
bcbogdan wants to merge 1 commit into
Conversation
Detect existing external ID mappings before insertion so permanent conflicts are reported as E031 instead of remaining in PROCESSING.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect existing external ID mappings before insertion so permanent conflicts are reported as E031 instead of remaining in PROCESSING.
Summary
Bulk imports could remain in
PROCESSINGindefinitely when an imported user reused an existing external user ID.The existing mapping was missed during validation, causing PostgreSQL to reject the insert. The worker classified that database error as transient and repeatedly retried it instead of marking the import as failed.
This ensures existing external ID mappings are detected before insertion, allowing the import to fail with
E031as expected.Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.getValidFieldsinio/supertokens/config/CoreConfig.javaif new aliases were added for any coreconfig (similar to the
access_token_signing_key_update_intervalconfig alias).git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.app_id_to_user_idtable, make sure to delete from this table when deletingthe user as well if
deleteUserIdMappingToois false.Remaining TODOs for this PR