Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ log messages for connection, method and query events #119

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Aug 5, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What does this change do?

This is the first PR regarding Observability.

  • Add logs in the app when using the client SDK
  • Works with built-in DI ILoggerFactory, or by manually providing one
  • Using 3 logger categories: Connection, Method and Query
  • Prevent application data from being written to logs, via SensitiveDataLoggingEnabled flag (for security reasons)
  • Set log level to information (except for one error log)

Examples

With SensitiveDataLoggingEnabled = false:

image

With SensitiveDataLoggingEnabled = true:

image

What is your testing strategy?

Unit tests & tests on an example project

Is this related to any issues?

Completes #12

Have you read the Contributing Guidelines?

@Odonno Odonno force-pushed the feat/logging branch 2 times, most recently from be8f4ad to 4c1fa72 Compare August 19, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant