Fix toolbar clipping on iOS 26.0: use 48pt instead of hard-coded 44pt#459
Merged
tommyming merged 1 commit intosuzuki-0000:masterfrom Sep 5, 2025
Merged
Conversation
tommyming
approved these changes
Sep 5, 2025
Collaborator
|
@Tuccuay lgtm! thanks and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On iOS 26.0,
UIToolbarheight is 48pt. Our image viewer computed a 44pt toolbar insideframeForToolbarAtOrientationand also usedclipsToBounds = true, which led to top/bottom clipping of bar button items on iOS 26.0.This MR updates
frameForToolbarAtOrientationto return a version-aware height and removes an unused helper function.What’s Changed
frameForToolbarAtOrientationto use 48pt on iOS 26.0 and 44pt on older iOS.clipsToBounds = true); only the height calculation changes.frameForToolbarHideAtOrientation(no remaining references).