This repository has been archived by the owner on Dec 28, 2019. It is now read-only.
working hot-reload and overkill refactor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored a bit more than I needed to but it made more sense to me this way.
The basic idea is that you can "register" multiple screens and that registry handles all the nasty stateful stuff and just delegates to whatever the "latest" definition is in the registry.
Since
react-native-navigationcontrols when and how the screens are created we can't do the other hacks I did inreagent-react-native.As far as I can tell everything is working as expected although I didn't properly forward the other events yet (ony
navigationButtonPressed). I kinda feel like the wholesetRootandpushbusiness could be abstracted in a friendlier way too.