-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pnpm
version 10
#432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b48209a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
bdb973c
to
dd80822
Compare
Merged
fnm install 22
# Installing Node v22.13.1 (x64)
# Enabling corepack for Node v22.13.1
node -v
# v22.13.1
pnpm -v
# 10.2.1 pnpm dlx sv create .
# ┌ Welcome to the Svelte CLI! (v0.6.19) - the latest version is used
# │
# ◇ Which template would you like?
# │ SvelteKit minimal
# │
# ◇ Add type checking with Typescript?
# │ Yes, using Typescript syntax
# │
# ◆ Project created
# │
# ◇ What would you like to add to your project? (use arrow keys / space bar)
# │ none
# │
# ◇ Which package manager do you want to install dependencies with?
# │ pnpm
# │
# ◆ Successfully installed dependencies - pnpm@10 used and is logged
# │
# ◇ Project next steps ─────────────────────────────────────────────────────╮
# │ │
# │ 1: git init && git add -A && git commit -m "Initial commit" (optional) │
# │ 2: pnpm run dev --open │
# │ │
# │ To close the dev server, hit Ctrl-C │
# │ │
# │ Stuck? Visit us at https://svelte.dev/chat │
# │ │
# ├──────────────────────────────────────────────────────────────────────────╯
# │
# └ You're all set! {
"name": "-temp",
"private": true,
"version": "0.0.1",
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build",
"preview": "vite preview",
"prepare": "svelte-kit sync || echo ''",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch"
},
"devDependencies": {
"@sveltejs/adapter-auto": "^4.0.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^5.0.0",
"svelte": "^5.0.0",
"svelte-check": "^4.0.0",
"typescript": "^5.0.0",
"vite": "^6.0.0"
},
"packageManager": "[email protected]+sha512.398035c7bd696d0ba0b10a688ed558285329d27ea994804a52bad9167d8e3a72bcb993f9699585d3ca25779ac64949ef422757a6c31102c12ab932e5cbe5cc92"
}
|
No you are not! Investigating! |
Fixed by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #424
closes #388
pnpm@10
to be able to reproduce the error described in the issues aboveesbuild
toonlyBuiltDependencies
when the users selectspnpm
during project initialization. This not only applies to project initialization, but to all projects that are usingpnpm
(even existing ones, as soon as you add another add-on to your project)sv.pnpmBuildDependendency
api, so that add-ons likedrizzle
(forbetter-sqlite3
) can provide further packages that should be added to that list.