Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pnpm version 10 #432

Merged
merged 18 commits into from
Feb 7, 2025
Merged

feat: support pnpm version 10 #432

merged 18 commits into from
Feb 7, 2025

Conversation

manuel3108
Copy link
Member

@manuel3108 manuel3108 commented Feb 1, 2025

closes #424
closes #388

  • updates monorepo to pnpm@10 to be able to reproduce the error described in the issues above
  • adds esbuild to onlyBuiltDependencies when the users selects pnpm during project initialization. This not only applies to project initialization, but to all projects that are using pnpm (even existing ones, as soon as you add another add-on to your project)
  • exposes the new sv.pnpmBuildDependendency api, so that add-ons like drizzle (for better-sqlite3) can provide further packages that should be added to that list.

Copy link

changeset-bot bot commented Feb 1, 2025

🦋 Changeset detected

Latest commit: b48209a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link

pkg-pr-new bot commented Feb 1, 2025

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@432
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@432

commit: b48209a

@manuel3108 manuel3108 force-pushed the feat/support-pnpm-10 branch 2 times, most recently from bdb973c to dd80822 Compare February 2, 2025 07:02
@manuel3108 manuel3108 marked this pull request as ready for review February 2, 2025 08:03
@manuel3108 manuel3108 added the pkg:add sv add label Feb 2, 2025
@manuel3108 manuel3108 merged commit 41cc5f6 into main Feb 7, 2025
7 checks passed
@manuel3108 manuel3108 deleted the feat/support-pnpm-10 branch February 7, 2025 12:08
@github-actions github-actions bot mentioned this pull request Feb 7, 2025
@hyunbinseo
Copy link
Contributor

onlyBuiltDependencies is not added in my environment. Am I missing something?

C:\Users\Hyunbin\Development\@temp> # working directory
fnm install 22
# Installing Node v22.13.1 (x64)
# Enabling corepack for Node v22.13.1

node -v
# v22.13.1

pnpm -v
# 10.2.1
pnpm dlx sv create .
# ┌  Welcome to the Svelte CLI! (v0.6.19) - the latest version is used
#
# ◇  Which template would you like?
# │  SvelteKit minimal
#
# ◇  Add type checking with Typescript?
# │  Yes, using Typescript syntax
#
# ◆  Project created
#
# ◇  What would you like to add to your project? (use arrow keys / space bar)
# │  none
#
# ◇  Which package manager do you want to install dependencies with?
# │  pnpm
#
# ◆  Successfully installed dependencies - pnpm@10 used and is logged
#
# ◇  Project next steps ─────────────────────────────────────────────────────╮
# │                                                                          │
# │  1: git init && git add -A && git commit -m "Initial commit" (optional)  │
# │  2: pnpm run dev --open                                                  │
# │                                                                          │
# │  To close the dev server, hit Ctrl-C                                     │
# │                                                                          │
# │  Stuck? Visit us at https://svelte.dev/chat                              │
# │                                                                          │
# ├──────────────────────────────────────────────────────────────────────────╯
#
# └  You're all set!
{
  "name": "-temp",
  "private": true,
  "version": "0.0.1",
  "type": "module",
  "scripts": {
    "dev": "vite dev",
    "build": "vite build",
    "preview": "vite preview",
    "prepare": "svelte-kit sync || echo ''",
    "check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
    "check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch"
  },
  "devDependencies": {
    "@sveltejs/adapter-auto": "^4.0.0",
    "@sveltejs/kit": "^2.16.0",
    "@sveltejs/vite-plugin-svelte": "^5.0.0",
    "svelte": "^5.0.0",
    "svelte-check": "^4.0.0",
    "typescript": "^5.0.0",
    "vite": "^6.0.0"
  },
  "packageManager": "[email protected]+sha512.398035c7bd696d0ba0b10a688ed558285329d27ea994804a52bad9167d8e3a72bcb993f9699585d3ca25779ac64949ef422757a6c31102c12ab932e5cbe5cc92"
}

@manuel3108
Copy link
Member Author

No you are not! Investigating!

@manuel3108
Copy link
Member Author

Fixed by 0.6.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:add sv add
Projects
None yet
2 participants