test: use Linter and ESLint directly from eslint in tests
#1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses eslint's own `Linter` rather than the compat layer.
Uses the `loadESLint` helper directly from eslint instead.
🦋 Changeset detectedLatest commit: d10536e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
43081j
commented
Mar 31, 2025
| import plugin from '../../../src/index.js'; | ||
| import { ESLint } from '../../utils/eslint-compat.js'; | ||
| import { loadESLint, type ESLint as ESLintClass } from 'eslint'; |
There was a problem hiding this comment.
as far as i understand, ESLint here is the flat ESLint already. but when we force install 8.x in CI, it will be the legacy one at runtime. which is why we can't just import {ESLint} from 'eslint'
baseballyama
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops a few of the compat exports in tests and imports directly from eslint instead.
Linteralready seems to work in our tests for 8.x and 9.x directly.ESLintis the flat class in 9.x, but the legacy one in 8.x. Luckily, it providesloadESLintwhich can retrieve the flatESLintfor us in both versions, so we should no longer need the compat helper.We can't quite get rid of the
RuleTestercompat layer as 8.x doesn't export the flat rule tester from the index (it is only available through the unsupported-api entrypoint).