Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/a2b8ccc8e2f75a845dc139583d58c3bd98b0b7d6Open in |
🦋 Changeset detectedLatest commit: a2b8ccc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
teemingc
commented
Oct 16, 2026
teemingc
added
breaking change
needs-platform-tests
teemingc
marked this pull request as draft
October 16, 2026 13:39
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
Member
Author
|
/autofix |
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
teemingc
commented
Oct 16, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ottomated
requested changes
Oct 16, 2026
| * @param {string} [root] | ||
| * @param {string} [mode] | ||
| */ | ||
| function read_config(root = process.cwd(), mode = 'production') { |
Contributor
There was a problem hiding this comment.
This is only used
- In the vite plugin only to validate
- In
adaptafter building is finished
so we could just write to a local variable in the cloudflare plugin's config function instead of reimplementing the config loader
| config(config, env) { | ||
| if (env.command !== 'build') return; | ||
| const wrangler_config = read_config(config.root, env.mode); | ||
| validate_worker_settings(wrangler_config); |
Contributor
There was a problem hiding this comment.
No need to run validation twice
| output_config.assets.directory = posixify(path.relative(worker_dir, assets)); | ||
| fs.writeFileSync(`${worker_dir}/wrangler.json`, JSON.stringify(output_config, null, 2)); | ||
|
|
||
| const deploy_config_path = path.join(vite_config.root, '.wrangler/deploy/config.json'); |
Contributor
There was a problem hiding this comment.
Can we confirm this path is static?
teemingc
force-pushed
the
teemingc-remove-cloudflare-pages
branch
from
October 22, 2026 07:50
682173b to
7203124
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stacked on top of #17479
Integrates Cloudflare’s Vite plugin for Cloudflare Workers unbundled builds and
vite previewrunning withworkerd. It also rejectspaths.assetsconfiguration as you'd probably not use that with Cloudflare and there's no way to make it work withworkerd. Custom workers will be added in a follow-up PR