feat: add sv #32
feat: add sv #32
Conversation
|
If i undersand that correctly |
|
Running |
tests/sv.ts
Outdated
| branch: 'main', | ||
| build: 'pnpm build', | ||
| beforeTest: | ||
| 'pnpm playwright install chromium && pnpx storybook@latest --version', // prefetch the storybook cli to reduce fetching errors in tests |
There was a problem hiding this comment.
is the storybook cli used by the tests also always "latest"? what happens if they release a new major?
If possible make it a devDependency and call it via pnpm storybook just like playwright
There was a problem hiding this comment.
I do see the point you are making. Our storybook add-on just executes their cli, and does nothing else. That's why we decided to leave it up to the storybook team (and Jeppe is super responsive)
That said, adding it to the devDeps of the cli won't make the situation much better, as we would still need to remember to update the version there. But it would already be simple, since it's only in one repo.
But I have another idea, will check and report back.
|
main has been updated and should no longer have audit errors, changes to package.json & lockfile can be reverted here |
Adds
sv, Relates sveltejs/cli#622