Skip to content

docs: grammatical corrections #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2025
Merged

Conversation

DePasqualeOrg
Copy link
Contributor

This PR corrects two grammatical issues:

  • A few instances of a missing hyphen in "server-side rendering"
  • A common mistake in which "as such" is used as a synonym for "therefore", "thus", "so", "this means that", "for this reason", etc.

To illustrate the second issue, this sentence uses "as such" correctly:

reroute is considered a pure, idempotent function. As such, it must always return the same output for the same input and not have side effects.

The rule of thumb is that "such" should be able to be replaced with a noun phrase from the previous sentence:

reroute is considered a pure, idempotent function. As [a pure, idempotent function], it must always return the same output for the same input and not have side effects.

This sentence uses "as such" incorrectly:

For instance, if condition is true in the code snippet below, the code inside the if block will run and color will be evaluated. As such, changes to either condition or color will cause the effect to re-run.

In this case, I've replaced "As such" with "This means that", since "such" does not refer to an aforementioned noun phrase that could logically be the subject of the sentence. "as such" is not a synonym for "this means that":

For instance, if condition is true in the code snippet below, the code inside the if block will run and color will be evaluated. This means that changes to either condition or color will cause the effect to re-run.

Copy link

vercel bot commented Aug 1, 2025

@DePasqualeOrg is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@benmccann
Copy link
Member

Please read the message in the PR description:

If this is a documentation PR (i.e. changing content within apps/svelte.dev/content/docs), then this is the wrong repository to make those changes. The content in this folder is synced from other repositories. Therefore, these changes should be made in their respective repositories (at https://github.com/sveltejs/svelte or https://github.com/sveltejs/kit, or example).

@benmccann benmccann changed the title fix: Grammatical corrections docs: grammatical corrections Aug 4, 2025
@DePasqualeOrg
Copy link
Contributor Author

Whoops, sorry about that. I've updated this PR to only include the texts that belong to this repo. You can find the other changes in sveltejs/kit#14101 and sveltejs/svelte#16550.

Copy link

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
svelte-dev ✅ Ready (Inspect) Visit Preview Aug 8, 2025 7:01am

@eltigerchino
Copy link
Member

There's still some blog content that use "server side" without the hyphen in between.

@Rich-Harris Rich-Harris merged commit f5a7cc5 into sveltejs:main Aug 8, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants