fix: prevent component pre-mounting in async boundaries #16633
+20
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eebadcd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
|
|
The test passes locally. Not sure why the CI run failed. 
|
harshmandan
force-pushed
the
harsh/fix/prevent-component-pre-mounting
branch
from
5fb1ab6 to
1ac643f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Follows up #16624.
failing test case w/ 16624 | The same test case with this PR
Description:
This PR changes how deferred components and their effects are mounted. Earlier components inside svelte:boundary with await were being mounted immediately as offscreen fragments and then replaced/swapped after the promises resolved, triggering effects immediately.
In this PR mounting is deferred until promise is resolved (no offscreen fragment is created. Not sure if this has any implications 🤞).
So, this solves the original issue of changed lifecycle order and the component unmounting is also kept deferred.
Tests and linting
pnpm testand lint the project withpnpm lint